[Openmp-commits] [openmp] [OpenMP][NFC] Remove `DelayedBinDesc` (PR #74360)

Jon Chesterfield via Openmp-commits openmp-commits at lists.llvm.org
Tue Dec 5 13:01:15 PST 2023

JonChesterfield wrote:

I'm pretty sure libomptarget is racy in general. Initialising the same libomptarget from multiple threads is unlikely to work. Fortunately it is usually initialised by the constructor called from crt.

It looks like this was a workaround for HSA doing dubious things. At the time you were insistent that we had to work around HSA, and keep the workaround around so things would work with older versions of HSA once it was fixed. I wanted to hard error on that HSA version, where users continue using older ones until HSA stopped crawling the address space looking for profiler thing.

Have you reproduced the crash this code avoided - I think it would be a specific HSA version via dlopen?

I am nervous about extensive NFC without much test coverage. This looks like a functional change without any automated test coverage. What manual testing supports the change?


More information about the Openmp-commits mailing list