[Openmp-commits] [openmp] [OpenMP][NFC] Remove `DelayedBinDesc` (PR #74360)

Jon Chesterfield via Openmp-commits openmp-commits at lists.llvm.org
Tue Dec 5 08:43:12 PST 2023

JonChesterfield wrote:

It wasn't dead when we wrote it. It stopped HSA segfaulting when running any openmp programs.

The code might be dead now. I expect git log will find a "NFC" patch that changed the control flow so that this no guard no longer works, with no associated tests.

Naturally we don't test with dlopen'ed HSA on CI so when it stopped working we didn't notice.

As an argument against deleting dynamic_cuda and dynamic_hsa, instead of fixing them, those are the expected mechanisms by which `apt install llvm` might give users a working toolchain, since the distribution build machines generally won't have rocm or cuda installed to satisfy the link dependency.


More information about the Openmp-commits mailing list