[Openmp-commits] [openmp] [OpenMP][NFC] Remove `DelayedBinDesc` (PR #74360)

Johannes Doerfert via Openmp-commits openmp-commits at lists.llvm.org
Mon Dec 4 13:33:58 PST 2023

jdoerfert wrote:

> > > This was the original issue #60119. I think HSA might've solved this as well in future versions.
> > 
> > 
> > This code was from the very beginning either unused or racy. I don't see a point in keeping it. If the issue exists, we need to store delayed lib initialization in a different place.
> I'll wait until @JonChesterfield chimes in, since if I recall this patch did indeed resolve the issue caused by infinitely recursive constructor calls.

The part I am deleting did never resolve an issue w/o race or UB. The critical part in the original patch was to move the loadRTLs call earlier.
I included the reproducer of the original issue (#60119) which was not in our tests.
It passes just fine on my machine w/o this code.


More information about the Openmp-commits mailing list