[Openmp-commits] [openmp] [OpenMP] Fix libomptarget build issue (PR #74067)

Dominik Adamski via Openmp-commits openmp-commits at lists.llvm.org
Fri Dec 1 03:57:00 PST 2023


https://github.com/DominikAdamski created https://github.com/llvm/llvm-project/pull/74067

Libomptarget cannot be build because of the recent refactoring introduced in patch 148dec9fa43b :
[OpenMP][NFC] Separate Envar (environment variable) handling (#73994)

This patch moved handling of environment variables from libomptarget library. That's why we don't need usage of "llvm::omp::target" namespace if we handle environment variables.

>From 72f4d059f9ecf2ba350ce288089578f6e128e61f Mon Sep 17 00:00:00 2001
From: Dominik Adamski <dominik.adamski at amd.com>
Date: Fri, 1 Dec 2023 05:45:34 -0600
Subject: [PATCH] [OpenMP] Fix libomptarget build issue

Libomptarget cannot be build because of the recent refactoring
introduced in patch 148dec9fa43b :
[OpenMP][NFC] Separate Envar (environment variable) handling (#73994)

This patch moved handling of environment variables from libomptarget
library. That's why we don't need usage of "llvm::omp::target"
namespace if we handle environment variables.
---
 openmp/libomptarget/src/interface.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/openmp/libomptarget/src/interface.cpp b/openmp/libomptarget/src/interface.cpp
index a2f713459e1d0c9..ee1bd4932442b1f 100644
--- a/openmp/libomptarget/src/interface.cpp
+++ b/openmp/libomptarget/src/interface.cpp
@@ -454,7 +454,6 @@ EXTERN void __tgt_target_nowait_query(void **AsyncHandle) {
   // for the device operations (work/spin wait on them) or block until they are
   // completed (use device side blocking mechanism). This allows the runtime to
   // adapt itself when there are a lot of long-running target regions in-flight.
-  using namespace llvm::omp::target;
   static thread_local utils::ExponentialBackoff QueryCounter(
       Int64Envar("OMPTARGET_QUERY_COUNT_MAX", 10),
       Int64Envar("OMPTARGET_QUERY_COUNT_THRESHOLD", 5),



More information about the Openmp-commits mailing list