[Openmp-commits] [PATCH] D159311: [OpenMP] [test] Fix target_thread_limit.cpp to not assume 4 or more cores
Johannes Doerfert via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Thu Aug 31 18:14:27 PDT 2023
jdoerfert added a comment.
This does not impact the test in the way you describe. set_num_threads, and thread_limit, are both upper bounds only. We can still pick 1 thread and it is conformant.
Adding the call is fine, but we should instead increment a number, not check for printed lines. The final result should be 1 <= result <= 4.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159311/new/
https://reviews.llvm.org/D159311
More information about the Openmp-commits
mailing list