[Openmp-commits] [PATCH] D159119: [OpenMP] Enable optimization level for memory_manager.cpp OpenMP test.

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

doru1004 added a comment.

In D159119#4625678 <https://reviews.llvm.org/D159119#4625678>, @JonChesterfield wrote:

> Please add a reason why to the commit message. Is O3 <https://reviews.llvm.org/owners/package/3/> different to O2 <https://reviews.llvm.org/owners/package/2/> in terms of behaviour?
>
> Are we defaulting to O0 for all the runtime tests on amdgpu? That seems unlikely as O0 usually doesn't work, but equally might explain why some tests are disabled.

The initial test doesn't have an optimization level specified. Does it? If it had O2 <https://reviews.llvm.org/owners/package/2/> it would be fine, it would be passing. Please check this issue here: https://github.com/llvm/llvm-project/issues/65077

The rationale is this test is currently disabled but passes with O2 <https://reviews.llvm.org/owners/package/2/> or O3 <https://reviews.llvm.org/owners/package/3/> explicitly passed in. The test fails to compile with O0 and fails to run consistently with O1 <https://reviews.llvm.org/owners/package/1/> or no opt level specified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159119/new/

https://reviews.llvm.org/D159119