[Openmp-commits] [PATCH] D158546: [openmp] Fix flang detection for offloading test

Ethan Luis McDonough via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Aug 28 18:18:17 PDT 2023


elmcdonough updated this revision to Diff 554127.
elmcdonough added a comment.

Fixes the actual test.  Adding `!$omp declare target` to the offloaded function prevents the OMPFunctionFiltering <https://github.com/llvm/llvm-project/blob/main/flang/lib/Optimizer/Transforms/OMPFunctionFiltering.cpp#L67> pass from optimizing it out.  I'm not sure if we want public functions to be hidden from object files targeting GPUs, but I think that might be outside the scope of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158546/new/

https://reviews.llvm.org/D158546

Files:
  openmp/CMakeLists.txt
  openmp/README.rst
  openmp/libomptarget/test/CMakeLists.txt
  openmp/libomptarget/test/lit.cfg
  openmp/libomptarget/test/lit.site.cfg.in
  openmp/libomptarget/test/offloading/fortran/basic_array.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158546.554127.patch
Type: text/x-patch
Size: 6296 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230829/4f3e65c3/attachment.bin>


More information about the Openmp-commits mailing list