[Openmp-commits] [PATCH] D158543: [OpenMP][OMPT] Add OMPT support for `generic-elf-64bit` plugin

[Dhruva Chakrabarti via Phabricator via Openmp-commits]

dhruvachak added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/CMakeLists.txt:59-61
+    if ((OMPT_TARGET_DEFAULT) AND (LIBOMPTARGET_OMPT_SUPPORT))
+      target_link_libraries("omptarget.rtl.${tmachine_libname}" PRIVATE OMPT)
+    endif()
----------------
mhalk wrote:
> Mimicked the behavior we already use for other plugins.
> Now we do not link OMPT anymore, when its support was actually disabled.
> (using `-DLIBOMP_OMPT_SUPPORT` -OR- `-DLIBOMPTARGET_OMPT_SUPPORT` set to `OFF`)
> 
> Could someone confirm please, that this is sane?
> Mimicked the behavior we already use for other plugins.
> Now we do not link OMPT anymore, when its support was actually disabled.
> (using `-DLIBOMP_OMPT_SUPPORT` -OR- `-DLIBOMPTARGET_OMPT_SUPPORT` set to `OFF`)
> 
> Could someone confirm please, that this is sane?

Seems ok to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158543/new/

https://reviews.llvm.org/D158543