[Openmp-commits] [PATCH] D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/src/kmp_taskdeps.cpp:333
+                                                     kmp_depnode_t *sink,
+                                                     kmp_depnode_t *source) {
+  if (!source)
----------------
rpereira-dev wrote:
> jdoerfert wrote:
> > why is the order here swapped?
> Order remains the same for callers; the patch only swaps in this prototype as i believe it was mistakenly inverted
> (used to be `sink`  -> `source`, is now `source` -> `sink` )
This looks pretty confusing IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158544/new/

https://reviews.llvm.org/D158544