[Openmp-commits] [PATCH] D158170: [OpenMP][Archer] Avoid false positive for OpenMP tasking

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

The annotation is in `endTask` because in `startTask` there may already be data filled by the runtime?



================
Comment at: openmp/tools/archer/ompt-tsan.cpp:485
 
+  // store private data from start to end
+  size_t PrivateDataSize{0};
----------------
Can adjust the comment style to be consistent with the others?


================
Comment at: openmp/tools/archer/ompt-tsan.cpp:971
     return;
+  if (ompt_get_task_memory) {
+    if (FromTask->PrivateDataSize > 0)
----------------
Do we need this extra check? I think `PrivateDataSize` is guaranteed 0 if Archer is unable to get this information, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158170/new/

https://reviews.llvm.org/D158170