[Openmp-commits] [PATCH] D157725: Fix Slice Duplicate in Profiler

[Aaron Jarmusch via Phabricator via Openmp-commits]

jarmusch updated this revision to Diff 550781.
jarmusch added a comment.

I addressed @jdoerfert's recommendations while the discussion is ongoing.

@protze.joachim, from your description, I understand that the issue might not lie in the 
measurement itself but rather in the visualization process. That was my initial thought as
 well. Moreover, based on my brief understanding of the code, I noticed that __tgt_target_kernel
 always calls targetKernel, resulting in the timescope being invoked twice at practically the
 same time. Is this measurement necessary, or does it create a duplication that requires 
chrome://tracing to remove one for proper visualization?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157725/new/

https://reviews.llvm.org/D157725

Files:
  openmp/libomptarget/src/interface.cpp
  openmp/libomptarget/src/omptarget.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157725.550781.patch
Type: text/x-patch
Size: 5959 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230816/99034e6d/attachment.bin>