[Openmp-commits] [PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

Thu Aug 3 11:48:32 PDT 2023

AntonRydahl added a comment.

The unit test that fails, `flang/test/Driver/omp-driver-offload.f90`, also fails on main. I don't see that it should be related to this patch.

================
Comment at: flang/test/Driver/driver-help.f90:55
 ! HELP-NEXT: -fopenmp-version=<value>
-! HELP-NEXT:                        Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang
+! HELP-NEXT:                        Set OpenMP version (e.g. 45 for OpenMP 4.5, 51 for OpenMP 5.1). Default value is 51 for Clang and 11 for Flang
 ! HELP-NEXT: -fopenmp               Parse OpenMP pragmas and generate parallel code.
----------------
clementval wrote:
> jdoerfert wrote:
> > tianshilei1992 wrote:
> > > clementval wrote:
> > > > AntonRydahl wrote:
> > > > > tianshilei1992 wrote:
> > > > > > Does Flang also switch to 5.1 by default?
> > > > > As far as I know, `flang` is still OpenMP 1.1 by default but still depends on the same command line options as `clang`. 
> > > > `flang` does not differentiate between versions. 
> > > I see.
> > I would remove the flang part of the wording for now.
> +1
Thanks a lot for pointing this out. Is the new hep text fine?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156901/new/

https://reviews.llvm.org/D156901