[Openmp-commits] [PATCH] D124652: [OpenMP] [OMPT] [amdgpu] [5/8] Implemented device init/fini/load callbacks

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk added inline comments.


================
Comment at: openmp/libomptarget/CMakeLists.txt:70
   add_definitions(-DOMPTARGET_DEBUG)
-endif()
+# endif()
 
----------------
jdoerfert wrote:
> ?
Had some issues, that was a testing leftover -- sorry!


================
Comment at: openmp/libomptarget/plugins-nextgen/common/OMPT/OmptCallback.cpp:35
+  if (lookup)                                                                  \
+    dstFn = (srcFn##_t)lookup(#srcFn);
 
----------------
jdoerfert wrote:
> Style, here and elsewhere. We use LLVM code style in the plugins, at least outside the C-bindings.
Thanks! Should be addressed (catched three locations).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124652/new/

https://reviews.llvm.org/D124652