[Openmp-commits] [PATCH] D149391: [OpenMP] Add missing -L to libomptarget tests

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny created this revision.
jdenny added reviewers: jhuber6, JonChesterfield, jdoerfert, ye-luo.
jdenny added a project: OpenMP.
Herald added subscribers: sunshaoce, guansong, yaxunl.
Herald added a project: All.
jdenny requested review of this revision.
Herald added subscribers: jplehr, sstefan1.

Without this patch, if an incompatible libomptarget.so is present in a
system directory, such as /usr/lib64, check-openmp fails many
libomptarget tests with linking errors.  The problem appears to have
started at D129875 <https://reviews.llvm.org/D129875>, which landed as dc52712a0632 <https://reviews.llvm.org/rGdc52712a063241bd0d3a0473b4e7ed870e41921f>.  This patch extends
the libomptarget test suite config with a -L for the current build
directory of libomptarget.so.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149391

Files:
  openmp/libomptarget/test/lit.cfg


Index: openmp/libomptarget/test/lit.cfg
===================================================================
--- openmp/libomptarget/test/lit.cfg
+++ openmp/libomptarget/test/lit.cfg
@@ -64,7 +64,8 @@
 # compiler flags
 config.test_flags = " -I " + config.test_source_root + \
     " -I " + config.omp_header_directory + \
-    " -L " + config.library_dir;
+    " -L " + config.library_dir + \
+    " -L " + config.llvm_lib_directory
 
 if config.omp_host_rtl_directory:
     config.test_flags = config.test_flags + " -L " + \


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149391.517733.patch
Type: text/x-patch
Size: 526 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230427/3147928e/attachment.bin>