[Openmp-commits] [PATCH] D124652: [OpenMP] [OMPT] [amdgpu] [5/8] Implemented device init/fini/load callbacks

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/CMakeLists.txt:70
   add_definitions(-DOMPTARGET_DEBUG)
-endif()
+# endif()
 
----------------
?


================
Comment at: openmp/libomptarget/include/ompt_connector.h:104
 
-#undef DEBUG_PREFIX
+// #undef DEBUG_PREFIX
 
----------------
?


================
Comment at: openmp/libomptarget/plugins-nextgen/common/OMPT/OmptCallback.cpp:35
+  if (lookup)                                                                  \
+    dstFn = (srcFn##_t)lookup(#srcFn);
 
----------------
Style, here and elsewhere. We use LLVM code style in the plugins, at least outside the C-bindings.


================
Comment at: openmp/runtime/src/exports_so.txt:29
+        ompt_start_tool;      # OMPT start interface
+        ompt_libomp_connect;  # OMPT libomptarget interface
 
----------------
?


================
Comment at: openmp/runtime/src/kmp_utility.cpp:410
 typedef struct ompt_start_tool_result_t ompt_start_tool_result_t;
+
 // Define symbols expected by VERSION script
----------------
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124652/new/

https://reviews.llvm.org/D124652