[Openmp-commits] [PATCH] D148808: [OpenMP][libomptarget][AMDGPU] Enable optional active HSA wait state

Tue Apr 25 20:52:31 PDT 2023

ye-luo added a comment.

In D148808#4286873 <https://reviews.llvm.org/D148808#4286873>, @gregrodgers wrote:

> In D148808#4283842 <https://reviews.llvm.org/D148808#4283842>, @ye-luo wrote:
>
>> Why separate KERNEL_BUSYWAIT and DATA_BUSYWAIT? I don't feel the need of two separate controls.
>> What are the units? Documentation?
>
> It is a matter of priorities.  If you are doing async copies, you may not want them to every busy-wait because you have more important things to do on the CPU.

In the OpenMP context, when an OpenMP target without nowait reaches a signal wait. The user intention is busy/active waiting. There are no more important things to do on the CPU.
If nowait is added, events are used instead of signal wait. I think active waiting is always preferred.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148808/new/

https://reviews.llvm.org/D148808