[Openmp-commits] [PATCH] D148870: [OpenMP] Enable the IDE support for the device runtime

Fri Apr 21 09:32:20 PDT 2023

tianshilei1992 added a comment.

In D148870#4287138 <https://reviews.llvm.org/D148870#4287138>, @jhuber6 wrote:

> In D148870#4285793 <https://reviews.llvm.org/D148870#4285793>, @tianshilei1992 wrote:
>
>> In D148870#4285776 <https://reviews.llvm.org/D148870#4285776>, @jhuber6 wrote:
>>
>>> We should check if `CMAKE_EXPORT_COMPILE_COMMANDS` is on as well.
>>
>> I'm not sure that is necessary, though this is mostly only for compile commands. I'd like it similar to `LLVM_ENABLE_IDE`.
>
> I'm not sure familiar with that option, but I guess that makes sense. I still think this is something that should probably be on by default if we have compile commands on though.

I can add that, say if we have that CMake option turned on, we enable this, or `LIBOMPTARGET_DEVICE_RTL_IDE_SUPPORT` is on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148870/new/

https://reviews.llvm.org/D148870