[Openmp-commits] [PATCH] D148393: [OpenMP] Additional APIs used by MSVC compiler for loop collapse (rectangular and non-rectangular loops)

[Natalia Glagoleva via Phabricator via Openmp-commits]

natgla added a comment.

In D148393#4283876 <https://reviews.llvm.org/D148393#4283876>, @jlpeyton wrote:

> Are there any plans to update clang itself to call these new API functions?

I think it could be valuable. We are doing measurements now to see how this compares to clang implementation. If not too well, it's possible that we'll need additional implementations of these APIs first. Also I can show up on one of Wednesday mornings to talk about this if it's something people will be interested in.



================
Comment at: openmp/runtime/src/dllexports:404-406
+        __kmpc_process_loop_nest_rectang    292
+        __kmpc_calc_original_ivs_rectang    293
+        __kmpc_for_collapsed_init           294
----------------
jlpeyton wrote:
> Why are we adding more ordinal numbers? I thought they weren't  necessary anymore.
Change was done and tested before removal of ordinals, I didn't re-test without them


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148393/new/

https://reviews.llvm.org/D148393