[Openmp-commits] [PATCH] D148178: [OpenMP][libomptarget] Improve plugin device info printing

[Jose Manuel Monsalve Diaz via Phabricator via Openmp-commits]

josemonsalve2 added a comment.

Other than the comment this looks good to me, cleaner than before. Thanks Kevin.



================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h:91
 
+enum InfoLevelKind { InfoLevel1 = 1, InfoLevel2, InfoLevel3 };
+
----------------
Maybe, add a comment to explain what level means. 

`/// Level represents the level in the info tree print (i.e. indentation)`

Or something like that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148178/new/

https://reviews.llvm.org/D148178