[Openmp-commits] [PATCH] D136103: OpenMP asynchronous memory copy support

[Jisheng Zhao via Phabricator via Openmp-commits]

jz10 updated this revision to Diff 470684.
jz10 added a comment.

Thanks Shilei

1. "Can you check all resolved comments to make sure there is no open comments?"

checked through the comments you and Johannes made, no more issues

2. "Since this function is not part of `libomp` and it's not gonna be an interface function, no need to name it as `__kmpc`."

revised helper functions' names


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136103/new/

https://reviews.llvm.org/D136103

Files:
  openmp/libomptarget/include/interop.h
  openmp/libomptarget/src/api.cpp
  openmp/libomptarget/src/exports
  openmp/libomptarget/src/private.h
  openmp/libomptarget/test/api/omp_target_memcpy_async1.c
  openmp/libomptarget/test/api/omp_target_memcpy_async2.c
  openmp/libomptarget/test/api/omp_target_memcpy_rect_async1.c
  openmp/libomptarget/test/api/omp_target_memcpy_rect_async2.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136103.470684.patch
Type: text/x-patch
Size: 21777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20221026/d95cc1d4/attachment-0001.bin>