[Openmp-commits] [PATCH] D136103: OpenMP asynchronous memory copy support

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

In D136103#3880651 <https://reviews.llvm.org/D136103#3880651>, @jz10 wrote:

> I checked through private.h, this header actually does the functionality
> that contains all kmp and kmpc related data structures and APIs, so should
> we still have to split a separate header file?

Yeah you are right. Nah, that's fine. Let it be for now.

Can you add a couple of tests?



================
Comment at: openmp/libomptarget/src/api.cpp:243
+  int Gtid = __kmpc_global_thread_num(nullptr);
+  int (*Fn)(kmp_int32, kmp_task_t *) = &__kmpc_target_memcpy_async_helper;
+
----------------
potentially an `auto *Fn` is more appropriate here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136103/new/

https://reviews.llvm.org/D136103