[Openmp-commits] [PATCH] D134396: [OpenMP][libomptarget] New plugin infrastructure and new CUDA plugin

Mon Oct 24 07:40:27 PDT 2022

kevinsala added inline comments.

================
Comment at: openmp/libomptarget/plugins-nextgen/generic-elf-64bit/src/rtl.cpp:28
+#include "llvm/Support/DynamicLibrary.h"
+
+// The number of devices in this plugin.
----------------
jhuber6 wrote:
> In the previous implementation, we used some definitions so that the debug messages indicated which plugin was executing. Right now I just see messages like this.
> ```
> PluginInterface --> Launching kernel __omp_offloading_10302_4741dfd_main_l5 with 1 blocks and 1 threads in Generic mode
> ```
> 
> I'm thinking we should be able to add a name for each subclass of the generic plugin to use for the debugging messages. I think it would also be nice to move away from the `DP(` macros if possible.
> 
> This isn't really high priority so I wouldn't worry about it for now.
I agree. That's something I had as TODO, but as you commented, it's not a high priority right now. We could probably switch to C++ templated functions for debug/info/report, automatically adding the prefix of the running plugin, and stop using the `TARGET_NAME` and `DEBUG_PREFIX` macros in these new plugins.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134396/new/

https://reviews.llvm.org/D134396