[Openmp-commits] [PATCH] D136103: OpenMP asynchronous memory copy support

[Jisheng Zhao via Phabricator via Openmp-commits]

jz10 updated this revision to Diff 469810.
jz10 added a comment.

Thanks Johannes

1. 'I feel like I'm missing something. As said before, all but 3 lines are identical in these two functions.

Now you created a helper for 1/3 of those identical lines but left the other 2/3 being duplicated. Could
you elaborate why?'
I put the common part into task_creation function


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136103/new/

https://reviews.llvm.org/D136103

Files:
  openmp/libomptarget/include/interop.h
  openmp/libomptarget/src/api.cpp
  openmp/libomptarget/src/exports
  openmp/libomptarget/src/private.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136103.469810.patch
Type: text/x-patch
Size: 14032 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20221021/0c322b28/attachment-0001.bin>