[Openmp-commits] [PATCH] D132005: [OpenMP] Add non-blocking support for target nowait regions

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/include/omptarget.h:189
+public:
+  enum class SyncTypeTy { BLOCKING, NON_BLOCKING };
+
----------------
`SyncTypeTy` looks weird. It's like having an LLVM class called `TypeTy`. I think `SyncTy` or `SyncType` are both fine.


================
Comment at: openmp/libomptarget/src/interface.cpp:84
+  int Rc = OFFLOAD_SUCCESS;
+  Rc = TargetDataFunction(Loc, Device, ArgNum, ArgsBase, Args, ArgSizes,
+                          ArgTypes, ArgNames, ArgMappers, AsyncInfo,
----------------
nit: `targetDataFunction`


================
Comment at: openmp/runtime/src/kmp_tasking.cpp:5199
+*/
+KMP_EXPORT bool __kmpc_omp_has_task_team(kmp_int32 gtid) {
+  kmp_info_t *thread = __kmp_thread_from_gtid(gtid);
----------------
Do we need to check if `gtid` is valid here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132005/new/

https://reviews.llvm.org/D132005