[Openmp-commits] [PATCH] D136103: OpenMP asynchronous memory copy support

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/api.cpp:405
+  return Rc;
+}
+
----------------
Now we have a first helper for the "async" part, we still should deduplicate the entry point code. Above, all but lines 385-387 are the same as in `omp_target_memcpy_async`. Can we also not duplicate those lines?

In this code there are also various places with variables not named according to the style guide, e.g. _Count, and with names not helpful, e.g. ErrXYZ. Please address those too. Similarly, use nullptr instead of NULL.

The problem with the int32 Flags I mentioned already. Let's avoid type punning and create the object with the right type from the very beginning.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136103/new/

https://reviews.llvm.org/D136103