[Openmp-commits] [PATCH] D136103: OpenMP asynchronous memory copy support

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/api.cpp:264
+  if (DepObj_Count > 0) {
+    DepObjs = new kmp_depend_info_t[DepObj_Count];
+    for (int i = 0; i < DepObj_Count; i++) {
----------------
Use an llvm::SmallVector


================
Comment at: openmp/libomptarget/src/api.cpp:387
+  return Rc;
+}
+
----------------
jdoerfert wrote:
> This screams helper as it is literally the same code modulo 5 characters in a few places. Please refactor and run clang-format on the patch.
^^^


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136103/new/

https://reviews.llvm.org/D136103