[Openmp-commits] [PATCH] D136103: OpenMP asynchronous memory copy support

[Jisheng Zhao via Phabricator via Openmp-commits]

jz10 updated this revision to Diff 468695.
jz10 added a comment.

Thanks Johannes for your comments, and I relied them below

1. format issues

I ran clang-format to reformat, please check if there's any missed things;

2. replace '0' with 'nullptr'

fixed

3. proper return value for helper functions and async functions

fixed

4. Why can't we have a `kmp_tasking_flags_t` object?

I followed the same access approach in openmp/runtime , so I didn't change this part. But I can revise if it is needed

5. make helper function as 'static'

fixed

6. Why do you access args_ for some parts and not for others? That said, where does the hidden helper need access to the dependences anyway?

there's type cast for depend objects from 'omp_depend_t' to 'kmp_depend_info_t*', and the array of casted depend objects is consumed by '__kmpc_omp_task_with_deps' , to make it safe, I just make larray of casted depend objects to live longer, thus attached it to Args object.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136103/new/

https://reviews.llvm.org/D136103

Files:
  clang/docs/ReleaseNotes.rst
  openmp/libomptarget/include/interop.h
  openmp/libomptarget/src/api.cpp
  openmp/libomptarget/src/exports
  openmp/libomptarget/src/private.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136103.468695.patch
Type: text/x-patch
Size: 14839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20221018/34d1501b/attachment.bin>