[Openmp-commits] [PATCH] D135795: Avoid exporting 80-bit fp functions for architectures other than Intel.

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton added inline comments.


================
Comment at: openmp/runtime/src/dllexports:819-820
     # These are specific to x86 and x64
     %ifndef arch_64
     %ifndef arch_aarch64
 
----------------
malharJ wrote:
> jlpeyton wrote:
> > Replace these two lines with `#ifdef IS_IA_ARCH` (and corresponding `%endif`)
> I'm a little unsure if that is having the same semantics ?
> If I understand correctly you have suggested this because of the comment on line 818 ?
> 
> but I see 
> ```
> %ifdef arch_32
> ```
> on line 839 (and it is inside the ifdef)
I think this change is OK, or I fail to see any issue.

Just for reference, 
  - arch_32 = x86
  - arch_32e = x64
  - arch_64 = unused. It used to mean Itanium, but it is not currently possible to produce it anymore.

So having
```
# Both x86 and x64
%ifdef IS_IA_ARCH
... Both x86 and x64 exports
%ifdef arch_32
# Only x86 exports
%endif
...
%endif 
```

Seems fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135795/new/

https://reviews.llvm.org/D135795