[Openmp-commits] [PATCH] D134396: [OpenMP][libomptarget] New plugin infrastructure and new CUDA plugin

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

@jhuber6 @tianshilei1992 Can we merge this and address changes in-tree?



================
Comment at: openmp/libomptarget/include/Utilities.h:57
+  std::string consumeString() { return toString(std::move(*this)); }
+};
+
----------------
Moving *this, couldn't that invalidate *this? If we know this is save, add a comment about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134396/new/

https://reviews.llvm.org/D134396