[Openmp-commits] [PATCH] D71989: [OpenMP][IRBuilder] `omp task` support

Mike Rice via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Oct 13 10:36:32 PDT 2022


mikerice added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1369
+        FunctionType::get(Builder.getInt32Ty(), WrapperArgTys, false));
+    Function *WrapperFunc = dyn_cast<Function>(WrapperFuncVal.getCallee());
+    PointerType *WrapperFuncBitcastType =
----------------
The return value of this dyn_cast is not checked. Should this use cast instead (to satisfy static verifiers)? Or do you expect a nullptr return here? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71989/new/

https://reviews.llvm.org/D71989



More information about the Openmp-commits mailing list