[Openmp-commits] [PATCH] D135795: Avoid exporting 80-bit fp functions for architectures other than Intel.

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton added a comment.

Just a few comments.



================
Comment at: openmp/runtime/src/dllexports:759-762
     __kmpc_atomic_float10_add_fp           2135
     __kmpc_atomic_float10_sub_fp           2136
     __kmpc_atomic_float10_mul_fp           2137
     __kmpc_atomic_float10_div_fp           2138
----------------
Should these be guarded?


================
Comment at: openmp/runtime/src/dllexports:819-820
     # These are specific to x86 and x64
     %ifndef arch_64
     %ifndef arch_aarch64
 
----------------
Replace these two lines with `#ifdef IS_IA_ARCH` (and corresponding `%endif`)


================
Comment at: openmp/runtime/src/dllexports:1246-1248
+    %endif
     __kmpc_atomic_float10_max_cpt          2141
     __kmpc_atomic_float10_min_cpt          2142
----------------
Why aren't the _cpt versions guarded as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135795/new/

https://reviews.llvm.org/D135795