[Openmp-commits] [PATCH] D135630: [DeviceRTL] CMake fix using target-level dependency

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Oct 11 09:50:25 PDT 2022


tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:175
   )
+  add_dependencies(linked_${bclib_name} ${bc_files})
 
----------------
ye-luo wrote:
> tianshilei1992 wrote:
> > it occurs to me that, we also need to add `${LINK_TOOL}` to dependencies.
> Line 226. No?
oh, I missed that. My bad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135630/new/

https://reviews.llvm.org/D135630



More information about the Openmp-commits mailing list