[Openmp-commits] [PATCH] D138704: RFC: [openmp] Provide an assembly implementation of __kmp_invoke_microtask on ARM

Wed Nov 30 10:46:47 PST 2022

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

In D138704#3957350 <https://reviews.llvm.org/D138704#3957350>, @DavidSpickett wrote:

> https://clang.llvm.org/docs/OpenMPSupport.html doesn't mention Arm at all. Perhaps it should.

It probably should, feel free to change that. Also `openmp.llvm.org` if you want to provide more information.

> Landing this seems like a low risk to me.

Agreed.

> Anyone from the OpenMP side want to check my logic there? @jdoerfert perhaps?

I did not check "the logic" as I am not familiar with arm but given that the test works and the assembly was proof read I think this is good to go.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138704/new/

https://reviews.llvm.org/D138704