[Openmp-commits] [PATCH] D138785: [OMPT][test] Fix mismatch error between the current address and the return address

Limin Zhang via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Nov 30 00:18:25 PST 2022


Ami-zhang added a comment.

In D138785#3956297 <https://reviews.llvm.org/D138785#3956297>, @protze.joachim wrote:

> I did not argue against adding `((char *)addr) - 12`. But following the description in the comment, I think, `((char *)addr) - 4` should stay there, as this might still be valid for other cases (e.g., compiling with other optimization constraints?).

Yes,  when compiled with optimization,  `((char *)addr) - 4` is valid.
I have added it. 
Thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138785/new/

https://reviews.llvm.org/D138785



More information about the Openmp-commits mailing list