[Openmp-commits] [PATCH] D138389: [OpenMP][libomptarget] Add AMDGPU NextGen plugin with asynchronous behavior

[Kevin Sala Penadés via Phabricator via Openmp-commits]

kevinsala added a comment.





================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:137
+/// If the \p TargetID does not contain a feature (default), do not map it.
+StringRef parseTargetID(StringRef TargetID, StringMap<bool> &FeatureMap) {
+  if (TargetID.empty())
----------------
jdoerfert wrote:
> jhuber6 wrote:
> > arsenm wrote:
> > > Do we not have this in a shared place already?
> > I believe we have some support in `clang` somewhere, we could probably move that to somewhere in `llvm` and include it here instead.
> I used the github search and the only place I found that looks for the sramecc+ string is the existing AMD plugin (same function basically):
> https://github.com/llvm/llvm-project/blob/a35ad711d90497994701a99723a81badf3d4348e/openmp/libomptarget/plugins/amdgpu/src/rtl.cpp#L1855
If you find it fine, I can move it to a new utils header in `plugins-nextgen/amdgpu/` and be included by both AMDGPU plugins.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138389/new/

https://reviews.llvm.org/D138389