[Openmp-commits] [PATCH] D138704: RFC: [openmp] Provide an assembly implementation of __kmp_invoke_microtask on ARM

[David Spickett via Phabricator via Openmp-commits]

DavidSpickett added inline comments.


================
Comment at: openmp/runtime/src/z_Linux_asm.S:1452
+	// extra 8 bytes for gtid and tid.
+	mov	r5, #1
+	add	r5, r5, r3, lsr #1
----------------
mstorsjo wrote:
> DavidSpickett wrote:
> > This 1 here, is it part of the rounding or is it the extra 8 bytes for gtid and tid?
> This is the extra 8 bytes for gtid and tid.
Got it, that's why you say above that we're over allocating. Because of that we're ok with rounding down (rounding up would need some +1 somewhere).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138704/new/

https://reviews.llvm.org/D138704