[Openmp-commits] [PATCH] D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info

Natalia Glagoleva via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Nov 28 09:30:58 PST 2022


natgla added inline comments.


================
Comment at: openmp/runtime/test/tasking/bug_nested_proxy_task.c:54
+        struct { // flag as a set of 8 bits
+            unsigned in : 1;
+            unsigned out : 1;
----------------
sorry for being late here. if the bit field is defined as unsigned, the set of bit fields will take at least "unsigned" space (4 bytes). Judging by union with flag: do you want to define all these as kmp_uint8? (same below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137748/new/

https://reviews.llvm.org/D137748



More information about the Openmp-commits mailing list