[Openmp-commits] [PATCH] D138495: [openmp][mlir] Lower parallel if to new fork_call_if function.

Mon Nov 28 06:52:33 PST 2022

DavidTruby added inline comments.

================
Comment at: mlir/test/Target/LLVMIR/openmp-llvm.mlir:197
-// CHECK-LABEL: @test_nested_alloca_ip
-llvm.func @test_nested_alloca_ip(%arg0: i32) -> () {
-
----------------
kiranchandramohan wrote:
> Was there any particular reason to remove this test? Can you update this test instead?
This test was testing whether the tid.addr and zero.addr values were calculated in the correct basic block when the blocks were nested. Since these are now calculated inside `__kmpc_fork_call_if` when needed this test doesn't actually test anything any more.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138495/new/

https://reviews.llvm.org/D138495