[Openmp-commits] [PATCH] D138703: [openmp] Fix build break for less common architectures

[David Spickett via Phabricator via Openmp-commits]

DavidSpickett added inline comments.


================
Comment at: openmp/runtime/src/z_Linux_asm.S:185
+.endm
+#else // KMP_OS_DARWIN || KMP_OS_WINDOWS
+.macro COMMON name, size, align_power
----------------
This would be `!KMP_OS_DARWIN && !KMP_OS_WINDOWS`. Or `!(KMP_OS_DARWIN || KMP_OS_WINDOWS)` if you prefer.

You could also ifdef around just the `.common` line if you wanted to save repeating `.macro`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138703/new/

https://reviews.llvm.org/D138703