[Openmp-commits] [PATCH] D138689: [openmp] Support building for armv7 Windows with mingw tools

[David Spickett via Phabricator via Openmp-commits]

DavidSpickett added a comment.

> The proper solution would be to write an assembly version of __kmp_invoke_microtask for ARM too.

This looks fine on its own now that I understand the purpose.

> (I'm not sure if the runtime is meant to support older ARM architectures than the armv7 I'm used to writing assembly for, etc)

I remember from removing armv2/3 support this file `openmp/runtime/src/kmp_platform.h`. Though that checks for defines all the way back to armv2 so it's almost no use, I highly doubt anyone builds this for v2. The original Raspberry Pi is Armv6, there is still a Debian build for v4 I think. I suspect we don't know what the minimum should be, but keeping the C version isn't a bad option in that case.

Maybe it makes sense to xfail the number of arguments test on arm Windows as well? So when it comes time to fix both are accounted for (if that time is soon we'd remember, but if it's in a year's time, we won't).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138689/new/

https://reviews.llvm.org/D138689