[Openmp-commits] [PATCH] D137827: [openmp] Use z_Linux_asm.S to provide __kmp_invoke_microtask with Clang for Windows/aarch64

Thu Nov 24 06:27:16 PST 2022

DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: openmp/runtime/src/z_Linux_asm.S:153
+	ALIGN 2
+	.globl KMP_PREFIX_UNDERSCORE(\proc)
+KMP_PREFIX_UNDERSCORE(\proc):
----------------
mstorsjo wrote:
> DavidSpickett wrote:
> > I guess this is 2 byte function start alignment? I'd have guessed 4 so maybe I'm wrong.
> No, the `ALIGN` macro takes a power of two - so this sets 4 byte alignment.
> 
> (The `ALIGN` macro is probably used because the `.align` directive is inconsistent across platforms - that's why there are the `.p2align` and `.balign` directives too. But changing the existing code to use them instead would be a different change.)
Of course yes. Every time I have to read these things I get number of bytes mixed up with power of 2.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137827/new/

https://reviews.llvm.org/D137827