[Openmp-commits] [PATCH] D137827: [openmp] Use z_Linux_asm.S to provide __kmp_invoke_microtask with Clang for Windows/aarch64

Thu Nov 24 05:18:43 PST 2022

DavidSpickett added a comment.

> The C implementation of __kmp_invoke_microtask in z_Windows_NT-586_util.cpp relies on unguaranteed assumptions about the compiler behaviour

Meaning no reason to use the C version, that part is clear to me.

> I'm wrapping the .comm directive since the alignment in that directive is interpreted differently between ELF and COFF.

I didn't know this was a thing. Can you cite some documentation for the `.comm` behaviour?

I assume this passes whatever OpenMP testing we have. I'd be ok approving it on that basis.

================
Comment at: openmp/runtime/src/z_Linux_asm.S:153
+	ALIGN 2
+	.globl KMP_PREFIX_UNDERSCORE(\proc)
+KMP_PREFIX_UNDERSCORE(\proc):
----------------
I guess this is 2 byte function start alignment? I'd have guessed 4 so maybe I'm wrong.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137827/new/

https://reviews.llvm.org/D137827