[Openmp-commits] [PATCH] D138049: [OpenMP][libomp] Cleanup version script and exported symbols

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:9205
+#if !USE_DEBUGGER
+int __kmp_omp_debug_struct_info = FALSE;
+int __kmp_debugging = FALSE;
----------------
MaskRay wrote:
> Yes that I see a lot of `FALSE` in openmp/ since it was imported from a pretty old code base.
> Does 0 or false apply?
I think we should keep the same code style as before for consistence. That’s also one of the reasons that even new code for libomp still doesn’t use LLVM code style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138049/new/

https://reviews.llvm.org/D138049