[Openmp-commits] [PATCH] D137749: [openmp] [test] Unbreak tests that rely on hidden_helper_task on Windows

[Martin Storsjö via Phabricator via Openmp-commits]

mstorsjo marked 2 inline comments as done.
mstorsjo added a comment.

Thanks for the suggestions!



================
Comment at: openmp/runtime/test/tasking/hidden_helper_task/affinity.cpp:1
+// REQUIRES: linux
 // RUN: %libomp-cxx-compile
----------------
jlpeyton wrote:
> For these tests `affinity.cpp` and `gtid.cpp`, it seems appropriate to create a new Linux-only feature inside `openmp/runtime/test/lit.cfg` called hidden-helper (or something like it) and use that instead. It would fit best at around line 110 near where the affinity and some other features are added.
Sure, done.


================
Comment at: openmp/runtime/test/worksharing/for/kmp_sch_simd_guided.c:53-57
+#ifdef __linux__
 static int __kmp_hidden_helper_threads_num = 8;
+#else
+static int __kmp_hidden_helper_threads_num = 0;
+#endif
----------------
jlpeyton wrote:
> It's probably better to disable hidden helper threads since they aren't participating in this test.
> 
> You can modify the run line to 
> `RUN: %libomp-compile && env LIBOMP_USE_HIDDEN_HELPER_TASK=0 LIBOMP_NUM_HIDDEN_HELPER_THREADS=0 %libomp-run`
> 
> And also set `static int __kmp_hidden_helper_threads_num = 0`.
Ah, thanks! Yes that's probably better here. (I guess one could remove the whole logic for counting hidden helper threads here too, but I kept it and just set it to zero for now.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137749/new/

https://reviews.llvm.org/D137749