[Openmp-commits] [PATCH] D123572: [OpenMP] [OMPT] [2/8] Implemented a connector for communication of OMPT callbacks between libraries.

[Dhruva Chakrabarti via Phabricator via Openmp-commits]

dhruvachak added a comment.

In D123572#3921397 <https://reviews.llvm.org/D123572#3921397>, @jhuber6 wrote:

> Make sure the new files in `libomptarget` match the LLVM style for the variables and filenames. Otherwise looks file

I changed the new include filename to ompt_connector.h. The filename formats appear mixed to me. Specifically, libomp seems to use "-" as the separator while libomptarget and plugins seem to use "_".

About variables, I tried to use CamelCase as much as possible for the new code. The problem is that the new code has to use OMPT APIs and they have a different naming format. So it is hard to avoid a mixed format. If you are referring to any specific use, let me know and I can fix it in a separate commit. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123572/new/

https://reviews.llvm.org/D123572