[Openmp-commits] [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[Dhruva Chakrabarti via Phabricator via Openmp-commits]

dhruvachak added a comment.

@jhuber6

Turns out a rebase on top of trunk had ~200 test conflicts. During my last update in Sep, I had resolved all of the clang test conflicts and failures, there were only llvm test failures.

At this point, I checked out commit 92bc3fb5 <https://reviews.llvm.org/rG92bc3fb5b1f2ed1bd65acbac5334854a17b70d33> for all the failed tests (both clang and llvm tests) and then ran update_cc_test_checks.py on all of the auto-generated clang tests with the updated compiler. After this update, the test results look like the following:

make check-clang: Some of these may be new since the last iteration. But I believe most of them need some manual updates. I did not check all of the 7 tests below but I believe most of them are not autogenerated. I suggest looking at them after the llvm tests are regenerated properly.

********************

Failed Tests (7):

  Clang :: CodeGen/PowerPC/ppc64le-varargs-f128.c
  Clang :: OpenMP/nvptx_target_printf_codegen.c
  Clang :: OpenMP/parallel_copyin_combined_codegen.c
  Clang :: OpenMP/target_globals_codegen.cpp
  Clang :: OpenMP/target_map_codegen_hold.cpp
  Clang :: OpenMP/task_target_device_codegen.c
  Clang :: OpenMP/unroll_codegen_parallel_for_factor.cpp

Testing Time: 47.70s

  Skipped          :     4
  Unsupported      :  1490
  Passed           : 30113
  Expectedly Failed:    28
  Failed           :     7

make check-llvm: Other than spmdization_constant_prop, I think the rest of them have a C code snippet. These are the ones to look at first. These tests are not updated in the current rebased version. You may see the updates I made to them from the previous commit.

********************

Failed Tests (9):

  LLVM :: Transforms/OpenMP/custom_state_machines.ll
  LLVM :: Transforms/OpenMP/custom_state_machines_remarks.ll
  LLVM :: Transforms/OpenMP/gpu_state_machine_function_ptr_replacement.ll
  LLVM :: Transforms/OpenMP/spmdization.ll
  LLVM :: Transforms/OpenMP/spmdization_assumes.ll
  LLVM :: Transforms/OpenMP/spmdization_constant_prop.ll
  LLVM :: Transforms/OpenMP/spmdization_guarding.ll
  LLVM :: Transforms/OpenMP/spmdization_guarding_two_reaching_kernels.ll
  LLVM :: Transforms/OpenMP/spmdization_remarks.ll

Testing Time: 58.80s

  Skipped          :    59
  Unsupported      : 19062
  Passed           : 31988
  Expectedly Failed:    69
  Failed           :     9

make check-openmp: On amdgpu, this looks good.

********************

Expectedly Failed Tests (12):

  libomptarget :: amdgcn-amd-amdhsa :: mapping/data_member_ref.cpp
  libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_nested_default_mappers.cpp
  libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_nested_mappers.cpp
  libomptarget :: amdgcn-amd-amdhsa :: mapping/lambda_by_value.cpp
  libomptarget :: amdgcn-amd-amdhsa :: mapping/ompx_hold/struct.c
  libomptarget :: amdgcn-amd-amdhsa :: offloading/host_as_target.c
  libomptarget :: amdgcn-amd-amdhsa-LTO :: mapping/data_member_ref.cpp
  libomptarget :: amdgcn-amd-amdhsa-LTO :: mapping/declare_mapper_nested_default_mappers.cpp
  libomptarget :: amdgcn-amd-amdhsa-LTO :: mapping/declare_mapper_nested_mappers.cpp
  libomptarget :: amdgcn-amd-amdhsa-LTO :: mapping/lambda_by_value.cpp
  libomptarget :: amdgcn-amd-amdhsa-LTO :: mapping/ompx_hold/struct.c
  libomptarget :: amdgcn-amd-amdhsa-LTO :: offloading/host_as_target.c

Testing Time: 145.83s

  Unsupported      : 139
  Passed           : 613
  Expectedly Failed:  12

[100%] Built target check-openmp
[100%] Built target check-openmp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102107/new/

https://reviews.llvm.org/D102107