[Openmp-commits] [PATCH] D138002: [OpenMP][libomptarget] Build plugins-nextgen/common/PluginInterface with protected visibility

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Nov 14 18:57:10 PST 2022


jhuber6 added a comment.

In D138002#3926596 <https://reviews.llvm.org/D138002#3926596>, @kevinsala wrote:

> @jhuber6 Shouldn't we compile the `elf_common` "library" with protected visibility too?

It should be fine since everything links from a single library. The previous problem was because we had multiple libraries defining the same functions in the plugins.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138002/new/

https://reviews.llvm.org/D138002



More information about the Openmp-commits mailing list