[Openmp-commits] [PATCH] D138002: [OpenMP][libomptarget] Build plugins-nextgen/common/PluginInterface with protected visibility

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt:22-23
 
 set_property(TARGET PluginInterface PROPERTY POSITION_INDEPENDENT_CODE ON)
+set_property(TARGET PluginInterface PROPERTY CXX_VISIBILITY_PRESET protected)
 llvm_update_compile_flags(PluginInterface)
----------------
nit. I'd prefer it in a single target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138002/new/

https://reviews.llvm.org/D138002