[Openmp-commits] [PATCH] D137607: Add interop support for OpenMP AMD GPU plugin

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:2698
+      return OFFLOAD_FAIL;
+    } else {
+      (*AsyncInfo)->Queue = Queue;
----------------
No return after else.


================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:2709
+
+  return OFFLOAD_SUCCESS;
+}
----------------
Reverse the cases, small case first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137607/new/

https://reviews.llvm.org/D137607