[Openmp-commits] [PATCH] D137168: [OpenMP][mingw] Fix build for aarch64 target

Fri Nov 11 04:02:20 PST 2022

mstorsjo added a comment.

In D137168#3914853 <https://reviews.llvm.org/D137168#3914853>, @mstorsjo wrote:

> In D137168#3914777 <https://reviews.llvm.org/D137168#3914777>, @mstorsjo wrote:
>
>> I managed to sort out all the test failures - many of them were caused by using slight mismatches in version between the sources to build libomp.dll and for running tests, some caused by using a slightly older version of clang to build.
>
> Sorry, I realized I had only been testing it successfully in a Debug build - when built in Release mode there still are a couple failures that I need to sort out. Anyway, I'll let you know if I find anything relevant, and post patches when I have it sorted out.

I've sorted out these issues now - with one upcoming patch I'll send in a moment (plus the rest of the ones that are in review), all tests pass in the mingw/aarch64 configuration.

There's one test, worksharing/for/omp_for_schedule_guided.c, which seems to be fail spuriously though (both on aarch64, and on arm, which requires another patch), but mostly the tests do pass. I'm not sure if that one flaky tests do indicate potential issues with atomics somewhere, or what it is, since it's rather hard to debug when it works 4 times out of 5.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137168/new/

https://reviews.llvm.org/D137168